This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notice: https://go.dev/blog/go1.18
Open discussions on how to handle Go 1.18:
From what I understand, we haven't reached a consensus on changing the pattern of supporting latest 2 Go versions. That's why I propose this update as-is.
I'd really appreciate if we could do the next major unified CI release with #261 because it'd give us a chance that the release process itself succeeds without human intervention.
Finally, the
latest
released version ofstaticcheck
does not support Go 1.18 yet. The progress is tracked in dominikh/go-tools#1166 and, apparently, there were comments in some other issues that this is going to be complete in about a week. The question is: do we wait forstaticcheck
release or disable it in unified CI for now?Testing
.github-test-target
in sync: update CI config files .github-test-target#37 (this also showcases thestaticcheck
issue)