Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

update to Go 1.18.x #308

Closed
wants to merge 1 commit into from
Closed

update to Go 1.18.x #308

wants to merge 1 commit into from

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Mar 21, 2022

Release notice: https://go.dev/blog/go1.18

Open discussions on how to handle Go 1.18:

From what I understand, we haven't reached a consensus on changing the pattern of supporting latest 2 Go versions. That's why I propose this update as-is.

I'd really appreciate if we could do the next major unified CI release with #261 because it'd give us a chance that the release process itself succeeds without human intervention.

Finally, the latest released version of staticcheck does not support Go 1.18 yet. The progress is tracked in dominikh/go-tools#1166 and, apparently, there were comments in some other issues that this is going to be complete in about a week. The question is: do we wait for staticcheck release or disable it in unified CI for now?

Testing

@mvdan
Copy link
Contributor

mvdan commented Mar 21, 2022

I don't think we need to block adding Go 1.18 until the next staticcheck version is out. The main reason that staticcheck is broken with 1.18 is due to generics, but the vast majority of repos using unified CI will keep on supporting Go 1.17, meaning they generally can't use generics yet, unless they go for some funky business with //go:build go1.18.

This assumes that it will be painless to update staticcheck in a week's time once they do release proper support for Go 1.18, though. I assume that for most repos it would be a bit bothersome to merge the update to Go 1.18 this week, and a staticcheck update next week. For that reason, it might be best to wait a week until we deploy the Go 1.18 update.

@galargh
Copy link
Contributor Author

galargh commented Mar 21, 2022

I just realised this duplicates #307.

@galargh galargh closed this Mar 21, 2022
@galargh galargh deleted the go-1.18 branch March 21, 2022 13:32
@galargh galargh mentioned this pull request Mar 21, 2022
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants