Supports installing Timemachine from Tarball #1443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Mypy only used when generating the stubs for the C++ build.
* Ensures that can upload package to pypi and be installable. * Adopt the convention of package data described in https://setuptools.pypa.io/en/latest/userguide/datafiles.html#subdirectory-for-data-files
badisa
changed the title
* To verify that we can package the repo and install it.
This reverts commit b6fa09c.
mcwitt
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that if attempted to install Timemachine from a tarball, it would fail to install on linux, as the C++ files were not included. This PR allow us to install from tarballs as well as to use pypi servers, if we wanted to. Previously we have only installed from a local git repo or by pip installing from the github url.