Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve testing docs #133

Merged
merged 1 commit into from
Jan 16, 2025
Merged

docs: improve testing docs #133

merged 1 commit into from
Jan 16, 2025

Conversation

louise-poole
Copy link
Collaborator

No description provided.

version = 4
version = 3
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this okay? I was getting lots of issues with this being version 4 and the others being version 3 and this was the only thing that solved it. I can revert the change if this is bad - let me know.

setup_env.sh
Lastly, you need to activate the conda env:
```bash
conda activate tycho-protocol-sdk-testing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the script activates it for them

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the line in the script doing that so assumed so - but then whenever I ran the script it didn't activate? I had to manually activate afterwards...

echo "Setup complete."
echo "Run 'conda activate $ENV_NAME' to activate the environment."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, then we need to remove the line just above?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave it no? No harm in having it if it actually works for some people. For me it didn't so I added the instructions to activate it manually.

@louise-poole louise-poole merged commit ffd6da9 into main Jan 16, 2025
5 checks passed
@louise-poole louise-poole deleted the lp/improve-test-docs branch January 16, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants