Basic implementation of Email PODs in Z API #2194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrrliu
approved these changes
Jan 25, 2025
Comment on lines
+162
to
+163
| collectionId === "Devcon SEA" || | ||
| collectionId === "Email" |
There was a problem hiding this comment.
nit -- maybe make this an array const? something like VIRTUAL_COLLECTIONS (or another name) ?
| @@ -21,8 +30,16 @@ export function getPODsForCollections( | |||
| .flatMap((collectionId) => | |||
| collectionId === "Devcon SEA" | |||
| ? pcds.getAllPCDsInFolder("Devcon SEA") | |||
| : collectionId === "Email" | |||
There was a problem hiding this comment.
and then refactor this into a nice function if collection id is in VIRTUAL_COLLECTIONS
| } | ||
| }); | ||
| const pods = await z.pod.collection("Email").query(q); | ||
| console.log(pods); |
| console.log(pods); | ||
| setPODs(pods); | ||
| } catch (e) { | ||
| console.log(e); |
There was a problem hiding this comment.
Suggested change
| console.log(e); | |
| console.error(e); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a special "virtual collection" called Emails, which contains the user's Email PODs. Zapps can request permission to this collection, which will allow them to read the Email PODs directly, and to make proofs about them. Updates to the collection are not allowed.