Add documentation generation to GitHub's build-and-test #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Test failed in the expected way. Going to rebase on top of #2189 to ensure it passes. |
artwyman
force-pushed
the
artwyman/docs-test
branch
from
4550ead to
97e4875
Compare
|
I'm confused by the repeat failure. Seems like it's showing the same issue fixed in the parent PR, which I don't see when I test locally. Going to try tweaking a few things. |
|
Ah, I now suspect some interaction of force-push with the attempt by GitHub to block me pushing workflow changes with a client not authorized for them. Let's see what I can do with the GitHub client. |
artwyman
force-pushed
the
artwyman/docs-test
branch
from
7926a8c to
dce1f45
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 21, 2024
The config file changes related to include paths are what fixed the actual error. See #2190 for a proposed workflow change to detect this kind of breakage on PRs. I also addressed many (but not all) of the doc-generation warnings and broken links.
artwyman
force-pushed
the
artwyman/docs-test
branch
from
dce1f45 to
cccf4fb
Compare
|
Rebased after the parent PR merged. This is ready to review and merge @robknight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected to fail on the current state of main. Fix incoming in #2189, but I want to confirm this test would catch the issue.