Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin rugged to below 1.7 #452

Closed
wants to merge 1 commit into from
Closed

Pin rugged to below 1.7 #452

wants to merge 1 commit into from

Conversation

magni-
Copy link

@magni- magni- commented Oct 31, 2023

A bandaid until pronto is updated to support rugged 1.7

Fixes #447

@magni- magni- requested a review from a team as a code owner October 31, 2023 02:11
@ashkulz
Copy link
Member

ashkulz commented Oct 31, 2023

@magni- instead of merging this, I'd prefer to fix it properly. Would appreciate if you could post a reproduction on #447

@magni-
Copy link
Author

magni- commented Nov 2, 2023

Unfortunately I don't have the time right now. This is just supposed to be a bandaid, not a final fix, but it would help us avoid having broken dependabot PRs for pronto in all of our Ruby repos.

@ashkulz
Copy link
Member

ashkulz commented Nov 2, 2023

In that case, I think you should use the workaround for now, as I don't think it makes sense to merge this and undo it a few days later.

@ashkulz ashkulz closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rugged 1.7.1 breaks gem
2 participants
@magni- @ashkulz