Fix for issue #17?

pronamic · Nov 30, 2023 · a5aac99 · a5aac99
1 parent 64e37bc
commit a5aac99
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/src/Gateways/Gateway.php b/src/Gateways/Gateway.php
@@ -226,6 +226,17 @@ public function process_payment( $transaction ) {
 			throw new \Exception( \esc_html__( 'This gateway only supports one time payments.', 'pronamic_ideal' ) );
 		}
 
+		/**
+		 * Get invoice to get updated transaction total for trial.
+		 *
+		 * @link https://github.com/pronamic/wp-pronamic-pay-memberpress/issues/13
+		 * @link https://github.com/pronamic/wp-pronamic-pay-memberpress/issues/17
+		 * @link https://github.com/pronamic/memberpress/blob/v1.11.6/app/helpers/MeprTransactionsHelper.php#L252-L254
+		 */
+		MeprTransactionsHelper::get_invoice( $transaction );
+
+		$transaction->store();
+
 		// Create Pronamic payment.
 		$payment = Pronamic::get_payment( $transaction );
 

diff --git a/src/Pronamic.php b/src/Pronamic.php
@@ -12,7 +12,6 @@
 
 use MeprSubscription;
 use MeprTransaction;
-use MeprTransactionsHelper;
 use Pronamic\WordPress\Money\Money;
 use Pronamic\WordPress\Money\TaxedMoney;
 use Pronamic\WordPress\Pay\AddressHelper;
@@ -48,14 +47,6 @@ public static function get_payment( MeprTransaction $memberpress_transaction ) {
 		$memberpress_product      = $memberpress_transaction->product();
 		$memberpress_subscription = $memberpress_transaction->subscription();
 
-		/**
-		 * Get invoice to get updated transaction total for trial.
-		 *
-		 * @link https://github.com/pronamic/wp-pronamic-pay-memberpress/issues/13
-		 * @link https://github.com/pronamic/memberpress/blob/v1.11.6/app/helpers/MeprTransactionsHelper.php#L252-L254
-		 */
-		MeprTransactionsHelper::get_invoice( $memberpress_transaction );
-
 		// Title.
 		$title = sprintf(
 			/* translators: %s: payment data title */