Improve amount format.

pronamic · Jul 2, 2021 · 59650a0 · 59650a0
1 parent a57ee2a
commit 59650a0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/src/DataGeneralHelper.php b/src/DataGeneralHelper.php
@@ -72,8 +72,7 @@ public function set_order_description( $description ) {
 	/**
 	 * Set amount
 	 *
-	 * @param float $amount Amount in cents.
-	 *
+	 * @param string $amount Amount in cents.
 	 * @return DataGeneralHelper
 	 */
 	public function set_amount( $amount ) {

diff --git a/src/DirectLink/Gateway.php b/src/DirectLink/Gateway.php
@@ -71,7 +71,7 @@ public function start( Payment $payment ) {
 			->set_order_description( $payment->get_description() )
 			->set_param_plus( 'payment_id=' . $payment->get_id() )
 			->set_currency( $payment->get_total_amount()->get_currency()->get_alphabetic_code() )
-			->set_amount( $payment->get_total_amount()->get_cents() );
+			->set_amount( $payment->get_total_amount()->get_minor_units()->format( 0, '', '' ) );
 
 		// Alias.
 		if ( $this->config->alias_enabled ) {

diff --git a/src/OrderStandard/Gateway.php b/src/OrderStandard/Gateway.php
@@ -114,7 +114,7 @@ public function get_output_fields( Payment $payment ) {
 			->set_order_description( $payment->get_description() )
 			->set_param_plus( 'payment_id=' . $payment->get_id() )
 			->set_currency( $payment->get_total_amount()->get_currency()->get_alphabetic_code() )
-			->set_amount( $payment->get_total_amount()->get_minor_units() );
+			->set_amount( $payment->get_total_amount()->get_minor_units()->format( 0, '', '' ) );
 
 		// Alias.
 		$alias = $payment->get_meta( 'ogone_alias' );

diff --git a/tests/src/DataGeneralHelperTest.php b/tests/src/DataGeneralHelperTest.php
@@ -33,7 +33,7 @@ public function test_helper() {
 			->set_psp_id( 'test' )
 			->set_order_id( '1234' )
 			->set_order_description( 'order description' )
-			->set_amount( 1050 )
+			->set_amount( '1050' )
 			->set_currency( 'EUR' )
 			->set_customer_name( 'Mr. Test' )
 			->set_email( '[email protected]' )
@@ -47,7 +47,7 @@ public function test_helper() {
 				'PSPID'    => 'test',
 				'ORDERID'  => '1234',
 				'COM'      => 'order description',
-				'AMOUNT'   => 1050,
+				'AMOUNT'   => '1050',
 				'CURRENCY' => 'EUR',
 				'CN'       => 'Mr. Test',
 				'EMAIL'    => '[email protected]',

diff --git a/tests/src/OrderStandard/ClientTest.php b/tests/src/OrderStandard/ClientTest.php
@@ -42,7 +42,7 @@ public function test_signature_in_from_documentation() {
 		$ogone_data_general = new DataGeneralHelper( $ogone_data );
 
 		$ogone_data_general
-			->set_amount( 1500 )
+			->set_amount( '1500' )
 			->set_currency( 'EUR' )
 			->set_language( 'en_US' )
 			->set_order_id( '1234' );