Merge branch 'release/2.2.1'

.gitignore

@@ -5,6 +5,9 @@
 /composer.lock
 /vendor/
 
+# Composer bin plugin
+/vendor-bin/**/vendor
+
 # Eclipse
 /.buildpath
 /.project

.travis.yml

@@ -52,6 +52,8 @@ before_install:
     if [[ "$COVERAGE" != "1" && -f ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/xdebug.ini ]]; then
       phpenv config-rm xdebug.ini
     fi
+  # Set Xdebug mode for coverage.
+  - export XDEBUG_MODE=coverage
   # Raise PHP memory limit to 2048MB
   - echo 'memory_limit = 2048M' >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini
   # Validate composer.json file.
@@ -72,6 +74,10 @@ install:
   - composer self-update
   # Install Composer packages.
   - composer install
+  # PHPStan
+  - if [ "$PHPSTAN" == "1" ]; then composer bin phpstan install; fi
+  # Psalm
+  - if [ "$PSALM" == "1" ]; then composer bin psalm install; fi
   # Test on specific WordPress version.
   - composer require --dev --update-with-dependencies roots/wordpress:${WP_VERSION} wp-phpunit/wp-phpunit:${WP_VERSION}
   # List available packages.
@@ -87,9 +93,9 @@ script:
   # PHP Mess Detector
   - if [ "$PHPMD" == "1" ]; then composer run-script phpmd; fi
   # PHPStan
-  - if [ "$PHPSTAN" == "1" ]; then phpstan analyze; fi
+  - if [ "$PHPSTAN" == "1" ]; then composer run-script phpstan; fi
   # Psalm
-  - if [ "$PSALM" == "1" ]; then psalm; fi
+  - if [ "$PSALM" == "1" ]; then composer run-script psalm; fi
 
 after_success:
   - if [ "$COVERAGE" == "1" ]; then composer run-script coveralls; fi

CHANGELOG.md

@@ -7,6 +7,10 @@ This projects adheres to [Semantic Versioning](http://semver.org/) and [Keep a C
 ## [Unreleased][unreleased]
 -
 
+## [2.2.1] - 2021-01-21
+- Fixed using undefined variable.
+- Removed debug code.
+
 ## [2.2.0] - 2021-01-14
 - Simplified icon hover style.
 - Updated form action icon.
@@ -55,7 +59,8 @@ This projects adheres to [Semantic Versioning](http://semver.org/) and [Keep a C
 ## 1.0.0 - 2015-11-05
 - First release.
 
-[unreleased]: https://github.com/wp-pay-extensions/formidable-forms/compare/2.2.0...HEAD
+[unreleased]: https://github.com/wp-pay-extensions/formidable-forms/compare/2.2.1...HEAD
+[2.2.1]: https://github.com/wp-pay-extensions/formidable-forms/compare/2.2.0...2.2.1
 [2.2.0]: https://github.com/wp-pay-extensions/formidable-forms/compare/2.1.4...2.2.0
 [2.1.4]: https://github.com/wp-pay-extensions/formidable-forms/compare/2.1.3...2.1.4
 [2.1.3]: https://github.com/wp-pay-extensions/formidable-forms/compare/2.1.2...2.1.3

composer.json

@@ -42,23 +42,28 @@
 		"wp-pay/core": "^2.6"
 	},
 	"require-dev": {
-		"dealerdirect/phpcodesniffer-composer-installer": "^0.7.1",
-		"php-coveralls/php-coveralls": "^2.1",
+		"bamarni/composer-bin-plugin": "^1.4",
+		"dealerdirect/phpcodesniffer-composer-installer": "^0.7",
+		"php-coveralls/php-coveralls": "^2.4",
 		"phpcompatibility/php-compatibility": "^9.1",
 		"phpcompatibility/phpcompatibility-wp": "^2.0",
 		"phpmd/phpmd": "^2.7",
 		"phpunit/phpunit": "^5.7 || ^6.0",
 		"roots/wordpress": "^5.6",
 		"squizlabs/php_codesniffer": "^3.4",
-		"wp-coding-standards/wpcs": "^2.1",
+		"wp-coding-standards/wpcs": "^2.3",
 		"wp-phpunit/wp-phpunit": "^5.6"
 	},
 	"scripts": {
-		"coveralls": "vendor/bin/coveralls -v",
+		"coveralls": "vendor/bin/php-coveralls -v",
 		"phpcbf": "vendor/bin/phpcbf",
 		"phpcs": "vendor/bin/phpcs -s -v",
 		"phplint": "find src tests -name '*.php' | xargs -n 1 -P 4 php -l",
 		"phpmd": "vendor/bin/phpmd src,tests text phpmd.ruleset.xml --suffixes php",
-		"phpunit": "vendor/bin/phpunit"
+		"phpstan": "vendor/bin/phpstan analyse",
+		"phpunit": "vendor/bin/phpunit",
+		"post-install-cmd": "echo 'Optionally run: composer bin all install'",
+		"post-update-cmd": "echo 'Optionally run: composer bin all update'",
+		"psalm": "vendor/bin/psalm"
 	}
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "formidable-forms",
-  "version": "2.2.0",
+  "version": "2.2.1",
   "description": "Formidable Forms driver for the WordPress payment processing library.",
   "repository": {
     "type": "git",

phpstan.neon.dist

@@ -1,6 +1,9 @@
+includes:
+	- vendor-bin/phpstan/vendor/szepeviktor/phpstan-wordpress/extension.neon
 parameters:
 	customRulesetUsed: false
 	level: max
-	bootstrap: tests/bootstrap.php
+	bootstrapFiles:
+		- tests/phpstan/bootstrap.php
 	paths:
-		- src
+		- src/

psalm.xml.dist

@@ -33,7 +33,6 @@
         <MissingReturnType errorLevel="info" />
         <MissingPropertyType errorLevel="info" />
         <InvalidDocblock errorLevel="info" />
-        <MisplacedRequiredParam errorLevel="info" />
 
         <PropertyNotSetInConstructor errorLevel="info" />
         <MissingConstructor errorLevel="info" />

src/BankSelectFieldType.php

@@ -9,7 +9,7 @@
 /**
  * Title: Formidable Forms bank select field type
  * Description:
- * Copyright: 2005-2020 Pronamic
+ * Copyright: 2005-2021 Pronamic
  * Company: Pronamic
  *
  * @author  Remco Tolsma

src/Extension.php

@@ -21,7 +21,7 @@
 /**
  * Title: Formidable Forms extension
  * Description:
- * Copyright: 2005-2020 Pronamic
+ * Copyright: 2005-2021 Pronamic
  * Company: Pronamic
  *
  * @author  Remco Tolsma
@@ -360,7 +360,7 @@ public function redirect_for_payment( $entry_id, $form_id ) {
 		}
 
 		$entry = \FrmEntry::getOne( $entry_id, true );
-var_dump( $entry );exit;
+
 		/**
 		 * Build payment.
 		 */
@@ -404,7 +404,7 @@ public function redirect_for_payment( $entry_id, $form_id ) {
 		}
 
 		if ( empty( $payment->method ) ) {
-			if ( null !== $data->get_issuer_id() ) {
+			if ( null !== FormidableFormsHelper::get_issuer_from_form_entry( $form_id, $entry ) ) {
 				$payment->method = PaymentMethods::IDEAL;
 			} elseif ( $gateway->payment_method_is_required() ) {
 				$payment->method = PaymentMethods::IDEAL;

src/FormidableForms.php

@@ -8,7 +8,7 @@
 /**
  * Title: WordPress pay Formidable Forms
  * Description:
- * Copyright: 2005-2020 Pronamic
+ * Copyright: 2005-2021 Pronamic
  * Company: Pronamic
  *
  * @author  Remco Tolsma

src/FormidableFormsDependency.php

@@ -3,7 +3,7 @@
  * Formidable Forms Dependency
  *
  * @author    Pronamic <[email protected]>
- * @copyright 2005-2020 Pronamic
+ * @copyright 2005-2021 Pronamic
  * @license   GPL-3.0-or-later
  * @package   Pronamic\WordPress\Pay\Extensions\FormidableForms
  */

src/FormidableFormsHelper.php

@@ -3,7 +3,7 @@
  * Formidable Forms Helper
  *
  * @author    Pronamic <[email protected]>
- * @copyright 2005-2020 Pronamic
+ * @copyright 2005-2021 Pronamic
  * @license   GPL-3.0-or-later
  * @package   Pronamic\WordPress\Pay\Extensions\FormidableForms
  */

src/PaymentAction.php

@@ -8,7 +8,7 @@
 /**
  * Title: Formidable Forms payment action
  * Description:
- * Copyright: 2005-2020 Pronamic
+ * Copyright: 2005-2021 Pronamic
  * Company: Pronamic
  *
  * @author  Remco Tolsma

src/PaymentMethodSelectFieldType.php

@@ -13,7 +13,7 @@
 /**
  * Title: Formidable Forms payment method select field type
  * Description:
- * Copyright: 2005-2020 Pronamic
+ * Copyright: 2005-2021 Pronamic
  * Company: Pronamic
  *
  * @author  Remco Tolsma

tests/bootstrap.php

@@ -3,7 +3,7 @@
  * Bootstrap tests
  *
  * @author    Pronamic <[email protected]>
- * @copyright 2005-2020 Pronamic
+ * @copyright 2005-2021 Pronamic
  * @license   GPL-3.0-or-later
  * @package   Pronamic\WordPress\Pay\Extensions\FormidableForms
  */

tests/phpstan/bootstrap.php

@@ -0,0 +1,11 @@
+<?php
+/**
+ * Definitions for PHPStan.
+ *
+ * @author    Pronamic <[email protected]>
+ * @copyright 2005-2021 Pronamic
+ * @license   GPL-3.0-or-later
+ * @package   Pronamic\WordPress\Pay
+ */
+
+define( 'SCRIPT_DEBUG', true );

tests/src/FormidableFormsTest.php

@@ -7,7 +7,7 @@
 /**
  * Title: WordPress pay Formidable Forms test
  * Description:
- * Copyright: 2005-2020 Pronamic
+ * Copyright: 2005-2021 Pronamic
  * Company: Pronamic
  *
  * @author Remco Tolsma

vendor-bin/phpstan/composer.json

@@ -0,0 +1,6 @@
+{
+	"require-dev": {
+		"phpstan/phpstan": "^0.12",
+		"szepeviktor/phpstan-wordpress": "^0.7"
+	}
+}