Skip to content

Commit

Permalink
feat: Add nodeSelector and tolerantions option to promitor-agent-scra…
Browse files Browse the repository at this point in the history
…per (#26)

Co-authored-by: Tom Kerkhove <[email protected]>
  • Loading branch information
blafry and tomkerkhove authored Feb 2, 2021
1 parent fe46dfd commit 616a961
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 0 deletions.
2 changes: 2 additions & 0 deletions promitor-agent-resource-discovery/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ their default values.
| `health.liveness.verifyDependencies` | Indication if liveness probes should verify if Promitor can interat with external dependencies. Do note that this will contact all dependencies which can have performance impact, cause throttling or cascading failures when consumed very often. | `false` | |
| `health.liveness.delay` | Amount of seconds to wait before probing the container to verify if it's still alive | `5` | |
| `health.liveness.interval` | Amount of seconds to wait before probing the container again to verify if it's still alive after the last attempt | `30` | |
| `nodeSelector` | Node labels for pod assignment | `{}` |
| `tolerations` | Tolerations for pod assignment | `[]` |
| `resources` | Pod resource requests & limits | `{}` |
| `secrets.createSecret` | Indication if you want to bring your own secret level of logging | `true` | |
| `secrets.appKeySecret` | Name of the secret for Azure AD identity secret | `azure-app-key` |
Expand Down
8 changes: 8 additions & 0 deletions promitor-agent-resource-discovery/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ spec:
{{- if .Values.rbac.create }}
serviceAccountName: {{ template "promitor-agent-resource-discovery.serviceaccountname" . }}
{{- end }}
{{- if .Values.nodeSelector }}
nodeSelector:
{{- toYaml .Values.nodeSelector | nindent 8 }}
{{- end }}
{{- if .Values.tolerations }}
tolerations:
{{- toYaml .Values.tolerations | nindent 6 }}
{{- end }}
containers:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
Expand Down
3 changes: 3 additions & 0 deletions promitor-agent-resource-discovery/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,6 @@ rbac:
## If create is true, a name is generated using the fullname template
name: promitor-resource-discovery
annotations: {}

nodeSelector: {}
tolerations: []
2 changes: 2 additions & 0 deletions promitor-agent-scraper/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ their default values.
| `health.liveness.verifyDependencies` | Indication if liveness probes should verify if Promitor can interat with external dependencies. Do note that this will contact all dependencies which can have performance impact, cause throttling or cascading failures when consumed very often. | `false` | |
| `health.liveness.delay` | Amount of seconds to wait before probing the container to verify if it's still alive | `5` | |
| `health.liveness.interval` | Amount of seconds to wait before probing the container again to verify if it's still alive after the last attempt | `30` | |
| `nodeSelector` | Node labels for pod assignment | `{}` |
| `tolerations` | Tolerations for pod assignment | `[]` |
| `resources` | Pod resource requests & limits | `{}` |
| `secrets.createSecret` | Indication if you want to bring your own secret level of logging | `true` |
| `secrets.appIdSecret` | Name of the secret for Azure AD identity id | `azure-app-id` |
Expand Down
8 changes: 8 additions & 0 deletions promitor-agent-scraper/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ spec:
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.nodeSelector }}
nodeSelector:
{{- toYaml .Values.nodeSelector | nindent 8 }}
{{- end }}
{{- if .Values.tolerations }}
tolerations:
{{- toYaml .Values.tolerations | nindent 6 }}
{{- end }}
containers:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
Expand Down
3 changes: 3 additions & 0 deletions promitor-agent-scraper/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,6 @@ rbac:
## If create is true, a name is generated using the fullname template
name: promitor-scraper
annotations: {}

nodeSelector: {}
tolerations: []

0 comments on commit 616a961

Please sign in to comment.