rex.mart: submit mart build exceptions to sentry #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreypopp
approved these changes
May 6, 2021
| @@ -127,6 +127,8 @@ def __call__(self): | |||
| ) | |||
| ) | |||
|
|
|||
| get_sentry().captureException(sync=True) | |||
There was a problem hiding this comment.
I'd move this below to the else: branch (to be created) of the if entry.halt_on_failure:. Otherwise, I think, the exception will be reported twice if entry.halt_on_failure is True.
There was a problem hiding this comment.
I agree that's how it looks like it would work, but we tried using halt_on_failure at one point and we still didn't see mart errors reported in Sentry...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.