-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collector/mdadm: Support RAID metrics #3031
base: master
Are you sure you want to change the base?
Conversation
62d8a5a
to
a75d6b8
Compare
Not sure what's causing the error here, the logs seem okay (no |
711ae52
to
59a5f2d
Compare
The log indicates a diff between metrics and expected metrics: --- collector/fixtures/e2e-output.txt 2024-06-21 23:39:55.007539384 +0000 HELP node_md_disks Number of active/failed/spare disks of device.TYPE node_md_disks gaugenode_md_disks{device="md0",state="active"} 2 HELP node_md_state Indicates the state of md-device.TYPE node_md_state gaugenode_md_state{device="md0",state="active"} 1 |
Ah! It seems I didn't update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cc @SuperQ 🙂 |
collector/mdadm_linux_test.go
Outdated
package collector | ||
|
||
import ( | ||
"github.com/go-kit/log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a rebase to pick up the replacement slog
logging.
a508383
to
999b1c9
Compare
Use `sysfs` for RAID stats. Signed-off-by: Pranshu Srivastava <[email protected]>
Signed-off-by: Pranshu Srivastava <[email protected]>
Use
sysfs
for RAID stats. Also added tests for the collector.Fixes: #842