Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info_schema_tables: do not collect the (useless) sys schema #879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frivoire
Copy link

@frivoire frivoire commented Oct 2, 2024

This sys schema is another (mariadb-specific) "system" schema, introduced in MariaDB 10.6 (2021), cf: MariaDB's doc
EDIT: MySQL seems to be introducing also a sys schema in MySQL 8.4 (2024), cf: MySQL's doc

And it's not useful to collect metrics for this schema (and it's even counter-productive, cf the cost of storing the metrics afterwards).
So, let's just remove this schema, just like it's already performed for the other "system" schemas (ex: performance_schema) today to be consistent with all "system" schemas.

Note: it's my first PR here, so I'm not sure about the CI/tests, please forgive any mistake & tell me 🙏

@frivoire frivoire marked this pull request as ready for review October 2, 2024 15:47
@frivoire
Copy link
Author

I'm estimating this to be a fairly simple PR, so (according to https://github.com/prometheus/mysqld_exporter/blob/main/CONTRIBUTING.md):
cc @SuperQ

Thanks :)

@frivoire frivoire changed the title info_schema_tables: do not collect the sys schema info_schema_tables: do not collect the (useless) sys schema Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant