Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the instance struct to handle connections #859

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

s10
Copy link
Contributor

@s10 s10 commented Aug 12, 2024

The intent is to use the instance struct to hold the connection to the database as well as metadata about the instance:

  • version
  • flavor (mariadb or mysql)

Change is similar to prometheus-community/postgres_exporter#785

@s10 s10 marked this pull request as ready for review August 12, 2024 13:10
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a nice improvement.

collector/instance.go Outdated Show resolved Hide resolved
The intent is to use the instance struct to hold the connection
to the database as well as metadata about the instance:
- version
- flavor (mariadb or mysql)

Change is similar to prometheus-community/postgres_exporter#785

Signed-off-by: Vlad Gusev <[email protected]>
@SuperQ SuperQ merged commit 31bc75a into prometheus:main Aug 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants