Support MySQL 8.4 replicas syntax #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtanda
force-pushed
the
mysql84
branch
2 times, most recently
from
1243a11
to
74faaa0
Compare
Signed-off-by: Mitsuhiro Tanda <[email protected]>
SuperQ
requested changes
May 15, 2024
Signed-off-by: Mitsuhiro Tanda <[email protected]>
|
@SuperQ Thank you for the review! I have addressed the comments and made the necessary changes. Could you please review it again? |
|
I suppose we should add MySQL 8.4 to our CI pipeline. |
|
Thanks for merge!! |
|
Which version of docker solves this problem? |
oblitorum
pushed a commit
to shatteredsilicon/mysqld_exporter
that referenced
this pull request
Oct 16, 2024
* support MySQL 8.4 Signed-off-by: Mitsuhiro Tanda <[email protected]> --------- Signed-off-by: Mitsuhiro Tanda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In MySQL 8.4, several "Replication SQL syntax" commands have been deprecated, requiring the use of new syntax. During testing, it was confirmed that errors occur with the old syntax. This PR updates the code to be compatible with the new syntax. Could you please review this PR?
Details
The changes address the syntax errors that arise due to the deprecated commands. Below are the specific errors encountered:
For reference, you can find the MySQL 8.4 release notes here: MySQL 8.4 Release Notes.
Thank you for reviewing this PR!