Refactor collectors to not depend of kingpin to be configured #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marctc
force-pushed
the
refactor_collector
branch
2 times, most recently
from
3678363
to
0debdf3
Compare
marctc
changed the title
marctc
force-pushed
the
refactor_collector
branch
from
0debdf3
to
364b9c4
Compare
cristiangreco
force-pushed
the
refactor_collector
branch
from
364b9c4
to
dec628b
Compare
cristiangreco
added a commit
to grafana/alloy
that referenced
this pull request
Sep 10, 2024
From grafana/mysqld_exporter branch `refactor_collector`, including changes in prometheus/mysqld_exporter#774.
4 tasks
cristiangreco
added a commit
to grafana/alloy
that referenced
this pull request
Sep 10, 2024
From grafana/mysqld_exporter branch `refactor_collector`, including changes in prometheus/mysqld_exporter#774.
|
@SuperQ any change to get a review on this? @cristiangreco will take care of address comments. Thanks! |
cristiangreco
added a commit
to grafana/alloy
that referenced
this pull request
Sep 10, 2024
From grafana/mysqld_exporter branch `refactor_collector`, including changes in prometheus/mysqld_exporter#774.
cristiangreco
added a commit
to grafana/alloy
that referenced
this pull request
Sep 10, 2024
From grafana/mysqld_exporter branch `refactor_collector`, including changes in prometheus/mysqld_exporter#774.
cristiangreco
added a commit
to grafana/alloy
that referenced
this pull request
Sep 10, 2024
From grafana/mysqld_exporter branch `refactor_collector`, including changes in prometheus/mysqld_exporter#774.
cristiangreco
added a commit
to grafana/alloy
that referenced
this pull request
Sep 10, 2024
From grafana/mysqld_exporter branch `refactor_collector`, including changes in prometheus/mysqld_exporter#774.
cristiangreco
added a commit
to grafana/alloy
that referenced
this pull request
Sep 11, 2024
From grafana/mysqld_exporter branch `refactor_collector`, including changes in prometheus/mysqld_exporter#774.
cristiangreco
added a commit
to grafana/alloy
that referenced
this pull request
Sep 11, 2024
From grafana/mysqld_exporter branch `refactor_collector`, including changes in prometheus/mysqld_exporter#774.
cristiangreco
added a commit
to grafana/alloy
that referenced
this pull request
Sep 11, 2024
From grafana/mysqld_exporter branch `refactor_collector`, including changes in prometheus/mysqld_exporter#774.
cristiangreco
added a commit
to grafana/alloy
that referenced
this pull request
Sep 12, 2024
From grafana/mysqld_exporter branch `refactor_collector`, including changes in prometheus/mysqld_exporter#774.
cristiangreco
force-pushed
the
refactor_collector
branch
2 times, most recently
from
def4a11
to
7bc7b9d
Compare
This commit removes references to kingpin.CommandLine, allowing for the collector package to be used and configured with a custom kingpin (or no kingpin at all). The configuration for collectors has been moved to struct fields, which the kingpin flags populate at flag parse time. Co-authored-by: Robert Fratto <[email protected]> Signed-off-by: Marc Tuduri <[email protected]>
cristiangreco
force-pushed
the
refactor_collector
branch
from
7bc7b9d
to
1f5a899
Compare
|
@SuperQ would you have bandwidth to consider this PR for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes references to
kingpin.CommandLine, allowing for thecollector package to be used and configured with a custom kingpin (or no
kingpin at all).
The configuration for collectors has been moved to struct fields, which
the kingpin flags populate at flag parse time. This allows the exporter to be
embeddable in other programs.