Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display landing page on / #261

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

schoentoon
Copy link
Contributor

This would fix #241 we ran into this issue when some of our automated tests fully believed that node exporter was leaking a linux home directory as it was returning HTTP 200 on requests like .bash_history

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just noticed this when I was working on prometheus/graphite_exporter#278.

Minor simplification using the existing net/http function.

web/landing_page.go Outdated Show resolved Hide resolved
Signed-off-by: Toon Schoenmakers <[email protected]>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit 1855ceb into prometheus:master Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

response 200 when url is incorrect
2 participants