-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pprof links to landing page #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is an excellent idea!
It will make it a lot easier to get profiles from users.
@bboreham What do you think of adding something like this to Prometheus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea; I had some suggestions about wording.
What would you think if I said it should offer both pprof.me and flamegraph.com ?
Sure. I guess the page with most info about memory is |
3f2e63c
to
4e1370a
Compare
Make it easier for users to fetch and download pprof data for debugging. * Add a link to https://pprof.me for easy sharing. Signed-off-by: SuperQ <[email protected]>
It might be worth mentioning somewhere in docs that these links will be ineffectual (and most likely just bounce back to the landing page, albeit with additional path suffixes each time) unless the exporter imports |
My plan is to add pprof handling to the exporter-toolkit. |
Make it easier for users to fetch and download pprof data for debugging.