Split TLS client tests to handle Go 1.21+ error strings #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.21 introduced more granular / specific error strings for certain "bad certificate" scenarios[1]. As such, we need to split these tests and conditionally compile based on build tags. Fixes: prometheus#171, prometheus#187 [1]: golang/go@62a9948 Signed-off-by: Daniel Swarbrick <[email protected]>
Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Daniel Swarbrick <[email protected]>
Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Daniel Swarbrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.21 introduced more granular / specific error strings for certain "bad certificate" scenarios1. As such, we need to split these tests and conditionally compile based on build tags.
Fixes: #171, #187