jira integration

[jkroepke]

This PR track the Atlassian JIRA integration into Alertmanger.

See: #3577

Replaces: https://github.com/prometheus-community/jiralert

---

What I test:

• Jira Cloud only
• Create issues
• Auto-Close issue with resolve_transition
• Reopen issue with reopen_transition
• Reopen duration
• Custom Fields
• api_token_file

[k0ste]

Can this integration cover another of jiralert issue - is custom field for alert hash?
prometheus-community/jiralert#164

Current code search hash in hardcoded place - in labels

jql.WriteString(fmt.Sprintf(`project = "%s" and
labels=%q order by status ASC,
resolutiondate DESC`, n.conf.Project, key.Hash()))

Thanks

[jkroepke]

Sure. After merge. Everyone is invited to improve.

I would not like to add more feature here. Even I understand you request.

The current PR covery already a lot of cases to test. Adding more new features results into more testing. I would prefer to add new features in separate PRs.

[holger-waschke]

Is this implementation only for Jira Cloud or can I still use the on-premise API with a PAT Authentication?

[jkroepke]

Hi @holger-waschke

I'm not able to test on-premise. But you can enter an Server API Path to an on premise instance and the authentication is still auth basic which should work on on-premise, too.

The integration does not use any cloud specific features. If https://github.com/prometheus-community/jiralert works on-premise, this integration should work, too.

I remember that Issue handling, the Jira Software Server API v2 and Cloud API v2 is the same.

• https://docs.atlassian.com/software/jira/docs/api/REST/9.11.0/#api/2/issue
• https://developer.atlassian.com/cloud/jira/platform/rest/v2/api-group-issues/#api-rest-api-2-issue-post

But please keep in mind that this integration will always have best-effort since most users are not able to setup a on premise instance.

[simonpasquier]

Thanks for starting this! I haven't looked yet in details into the notifier but I suppose that it's almost a 1:1 copy from the original project?

Not a blocker but I think that it's the first notifier which needs to query the external system before actually sending the notification. It should be highlighted in the documentation IMHO.

[jkroepke]

Thanks for starting this! I haven't looked yet in details into the notifier but I suppose that it's almost a 1:1 copy from the original project?

No. while jiralert uses a unofficial outdated REST SDK for JIRA, I used the standard http client to setup the few http calls.

[jkroepke]

The code looks good to me. Unfortunately, I cannot test in my setup, because I have a problem with the field Labels. I'll way the code be merged to include https://github.com/prometheus-community/jiralert/

I‘m open to extend the feature set after this PR got merged.

Background: it seems like AM has some review capacity issues and increase the scope involves an additional review each time. The current scope is well tested (including manual test against prod systems).

[SuperQ]

Yes, I would like to see this merged so we can iterate on additional featres.

[simonpasquier]

json-iterator is already an indirect dependency via prometheus/client_golang so I'd say that it's ok to use it.

[SuperQ]

Some minor doc consistency nits.

[jkroepke]

Thanks for all the reviews.

• I had some issues with jsoniter (as replacement for tcontainer), but I struggle here. Tests are failing with jsoniter.
• I have implement a truncate for jira description (ref truncate descriptions that exceed -max-description-length (default 32KB) prometheus-community/jiralert#165) - also experienced this once already.
• The notify context will be passed to all API calls.
• I merged group_labels and static_labels as suggested by @simonpasquier

[jkroepke]

Hi all, after 2 approvals. how we should proceed?

[SuperQ]

Ping @gotjosh @simonpasquier

[simonpasquier]

I'll review by the end of the week, sorry for the delay.

[simonpasquier]

I'd have minor comments on making the code a bit more compact but nothing that should prevent merging this PR. Thanks again for your patience!
I'll also look into building a new RC for Alertmanager.