-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Initial support for CEL #267
base: master
Are you sure you want to change the base?
Conversation
@SuperQ @rustycl0ck any thoughts on this? Would love to get some early feedback to see if this is something you'd be interested in adding. |
Thanks a lot for this MR, just tested this branch and it seems to work fine. We used:
This should potentially solve a lot of related issues that need a bit more advance logic, such as: Please add a bit of documentation, then it would be perfect 🚀 |
@sbor23 thanks for testing it! I still need to figure out a couple of things here, I have updated the original messages |
75a0c7e
to
72ab3d8
Compare
I went ahead with the engine field solution
|
5a26a4a
to
bdc4eb9
Compare
d0c9753
to
5f61823
Compare
This adds initial support for queries using the common expression language (CEL). ValueToJSON function is adapted from https://github.com/google/cel-go/blob/cfbf821f1b458533051306305a39b743db7c4bdb/codelab/codelab.go#L274 (Apache-2.0 Licensed) Signed-off-by: Manuel Rüger <[email protected]>
This adds initial support for queries using the common expression language (CEL).
having additional separate fields
vs. defining an engine for the query
See: #263