Support parsing date type value #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very handy. Is there anything missing to get it merged? |
mitsutaka
force-pushed
the
parse-date
branch
from
f1709d1 to
d6b12f3
Compare
|
That indeed looks really interesting. Could we have this reviewed? |
|
Hi @SuperQ, Can you review this? |
|
Hi, any updates on this? @mitsutaka there are conflicts between the branches. I'm not a Golang expert but if you don't have time, I can (try to) help. |
Signed-off-by: Mitz Amano <[email protected]>
mitsutaka
force-pushed
the
parse-date
branch
from
54455aa to
1db40b5
Compare
|
Rebased. @fedaykin-b thanks for the heads up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (#138)
I also want this feature. Since there are no activities in the issue, I've raised PR based on the conversation instead.