Change transition order #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
free
reviewed
Dec 13, 2022
Comment on lines
+117
to
+122
| // Issue is set as won't fix. Discard. | ||
| if r.conf.WontFixResolution != "" && issue.Fields.Resolution != nil && | ||
| issue.Fields.Resolution.Name == r.conf.WontFixResolution { | ||
| level.Info(r.logger).Log("msg", "issue was resolved as won't fix, not reopening", "key", issue.Key, "label", issueGroupLabel, "resolution", issue.Fields.Resolution.Name) | ||
| return false, nil | ||
| } |
There was a problem hiding this comment.
Shouldn't this go at the very top? I.e. before the summary and/or description are updated?
Comment on lines
+97
to
+98
| // Issue is not dynamically updated, so we need to modify the Resolution to avoid creating duplicates on a "won't fix" situation | ||
| issue.Fields.Resolution = nil |
| @@ -115,19 +137,11 @@ func (r *Receiver) Notify(data *alertmanager.Data, hashJiraLabel bool) (bool, er | |||
| } | |||
|
|
|||
| // The set of JIRA status categories is fixed, this is a safe check to make. | |||
| if issue.Fields.Status.StatusCategory.Key != "done" { | |||
| if issue.Fields.Resolution == nil { | |||
There was a problem hiding this comment.
I don't understand this either.
Since the issue is about Jira not allowing editing issues in certain states (which presumably covers the summary and description), shouldn't the fix be to just move updating of the summary and description after the r.reopen()?
As is, the code first tries to reopen the issue (and edit it). Then it checks whether it should be reopened. Then resolves it, if no alerts are firing. Finally, if it has just reopened the issue, it logs "issue is unresolved" and exits. Seems kind of random.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
We have noticed that Jira blocks the
Editaction in certain states, causing the integration to fail if these issues aren't transitioned before trying to update the description.This PR changes the order of operations to avoid updating issues before setting them to the desired state.
Cheers