[kube-prometheus-stack] bump prom to 3.0.1 to align with upstream default #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrFaust92
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
jkroepke
requested changes
Dec 15, 2024
There was a problem hiding this comment.
Since Prometheus is a core components of this chart, i would like to follow the same principal of grafana/helm-charts#3139 and would like to request and major version bump here, including a not that the default Prometheus version has been raised to v3.
While it may not break something, our users should be aware of that change.
|
jkroepke LMK if this what you intended |
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
DrFaust92
force-pushed
the
bump-prom-3.0.1
branch
from
ef1dae9 to
88b6653
Compare
jkroepke
reviewed
Dec 16, 2024
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
reviewed
Dec 16, 2024
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator v0.79.0 default prom version is not 3.0.1
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])