[kube-prometheus-stack] Chore: Improve kubelet ServiceMonitor #5061
+38
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
SuperQ
force-pushed
the
superq/refactor-kubelet_servicemonitor
branch
3 times, most recently
from
d2beccb to
bcf679a
Compare
jkroepke
reviewed
Dec 15, 2024
charts/kube-prometheus-stack/templates/exporters/kubelet/servicemonitor.yaml
Show resolved
Hide resolved
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jkroepke
reviewed
Dec 15, 2024
SuperQ
force-pushed
the
superq/refactor-kubelet_servicemonitor
branch
from
bcf679a to
c489a46
Compare
Refactor the Kubelet ServiceMonitor with a helper template for handling http/https schema. This will reduce the chance of copy-pasta mistakes when updating the different kubelet monitoring endpoints. * Define `kube-prometheus-stack.kubelet.scheme` for the port/schema. * Define `kube-prometheus-stack.kubelet.authConfig` for TLS access controls. Signed-off-by: SuperQ <[email protected]>
SuperQ
force-pushed
the
superq/refactor-kubelet_servicemonitor
branch
from
c489a46 to
f205a4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Refactor the Kubelet ServiceMonitor with a helper template for handling http/https schema. This will reduce the chance of copy-pasta mistakes when updating the different kubelet monitoring endpoints.
kube-prometheus-stack.kubelet.schemefor the port/schema.kube-prometheus-stack.kubelet.authConfigfor TLS access controls.Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])