[kube-prometheus-stack] Add instance label information to the prometheusrule description #5041
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviderli614
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
Signed-off-by: liyang <[email protected]>
daviderli614
force-pushed
the
chore/rule-instance-label
branch
from
8cf9c6c to
38cc9fb
Compare
daviderli614
changed the title
|
Hi @daviderli614, please check the header of the files you are changing. There is a specific procedure to update these. |
@GMartinez-Sisti |
|
Yeah that should be sufficient |
|
I want to wait until kube-prometheus is merged before modifying here. |
|
Yeah, that mandatory. Otherwise, the changes from this PR may get reverted by scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
I found that the description in the prometheusrule of
NodeHighNumberConntrackEntriesUsedandnode-networklacks the instance label. Adding this label helps to know the specific alarm instance.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])