Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-smartctl-exporter] Add support for device-include / device-exclude and image pull secrets #4990

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −2
Open

[prometheus-smartctl-exporter] Add support for device-include / device-exclude and image pull secrets #4990

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa862a3
Add support for device-include / device-exclude and image pull secrets
jmif Nov 11, 2024
96aa990
Change version to minor release, add defaults to values.yaml
jmif Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-smartctl-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.11.0
version: 0.11.1
jmif marked this conversation as resolved.
Show resolved Hide resolved

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
12 changes: 12 additions & 0 deletions charts/prometheus-smartctl-exporter/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,24 @@ spec:
{{- include "prometheus-smartctl-exporter.selectorLabels" $global | nindent 8 }}
idx: i{{ $idx }}
spec:
{{- if $global.Values.image.pullSecrets }}
imagePullSecrets:
jmif marked this conversation as resolved.
Show resolved Hide resolved
{{- range $secret := $global.Values.image.pullSecrets }}
- name: {{ $secret }}
{{- end }}
{{- end }}
containers:
- image: "{{ $global.Values.image.repository }}:{{ $global.Values.image.tag | default $global.Chart.AppVersion }}"
imagePullPolicy: {{ $global.Values.image.pullPolicy }}
args:
- '--smartctl.path={{ $config.smartctl_location }}'
- '--smartctl.interval={{ $config.collect_not_more_than_period }}'
{{- if $config.device_exclude }}
- '--smartctl.device-exclude={{ $config.device_exclude }}'
zeritti marked this conversation as resolved.
Show resolved Hide resolved
{{- end }}
{{- if $config.device_include }}
- '--smartctl.device-include={{ $config.device_include }}'
{{- end }}
{{ range $config.devices }}
- '--smartctl.device={{ . }}'
{{ end }}
Expand Down