[prometheus-blackbox-exporter] - Add extraConfigmapMounts to config-reloder helper template #4773
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for custom ConfigMap entries. Signed-off-by: Nirmal Ramakrishnan <[email protected]> Signed-off-by: Nirmal kumar Ramakrishnan <[email protected]>
Set condition to create configMap using values.config (in line modules) or secret if existing configMap is set to empty. Signed-off-by: Nirmal Ramakrishnan <[email protected]> Signed-off-by: Nirmal kumar Ramakrishnan <[email protected]>
Update chart version Signed-off-by: Nirmal Ramakrishnan <[email protected]> Signed-off-by: Nirmal kumar Ramakrishnan <[email protected]>
Update chart version Signed-off-by: Nirmal Ramakrishnan <[email protected]> Signed-off-by: Nirmal kumar Ramakrishnan <[email protected]>
nirmalkumar85
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
monotek
requested changes
Aug 7, 2024
New feature updating minor version. Addressing reviewers comments. Signed-off-by: Nirmal Ramakrishnan <[email protected]> Signed-off-by: Nirmal kumar Ramakrishnan <[email protected]>
Fixing syntax error in the template. Signed-off-by: Nirmal Ramakrishnan <[email protected]> Signed-off-by: Nirmal kumar Ramakrishnan <[email protected]>
monotek
requested changes
Aug 8, 2024
There was a problem hiding this comment.
what about the logic in the helpers file, like: https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus-blackbox-exporter/templates/_helpers.tpl#L291-L294 ?
Add support for custom ConfigMap entries. Signed-off-by: Nirmal Ramakrishnan <[email protected]> Signed-off-by: Nirmal kumar Ramakrishnan <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: Nirmal kumar Ramakrishnan <[email protected]>
|
Apologies @monotek. I was away for extended time due to personal reasons and not able to work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @desaintmartin @gianrubio @rsotnychenko @monotek
My first contribution and thanks.
What this PR does / why we need it
Adds extraConfigmapMounts to config-reloader. This will align with the blackbox exporter where extraConfigmapMounts can be supplied.
In blackbox, a user can use a custom Configmap for blackbox configurations via extraConfigmapMount option to support use cases where configMap for blackbox modules are dynamically generated by external application and would be supplied as a custom configMap managed outside the helmchart.
While we could convert all our non-sensitive configuration to a secret, however this is an anti-pattern in cases where additional process are required to validate secrets.
The blackbox-exporter supports extraConfigmapMounts, but the config-reloader has the following problem:
The reloader will watch this path - - --config-file={{ .Values.configPath | default "/config/blackbox.yaml" }}
In blackbox, a user can use a custom configmap for modules.
The config reloader cannot watch this mount.
helm-charts/charts/prometheus-blackbox-exporter/templates/_helpers.tpl
Line 201 in 34a6212
Checklist
[prometheus-couchdb-exporter])