[kube-state-metrics] Allow configuration of startupProbe #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Kienzler <[email protected]>
Signed-off-by: David Calvert <[email protected]>
dotdc
approved these changes
Jul 26, 2024
|
Thank you for your contribution @SimonKienzler ! |
|
Thanks for handling it so quickly @dotdc 🚀 |
3 tasks
kireque
referenced
this pull request
in kireque/home-ops
Jul 26, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kube-state-metrics](https://togithub.com/kubernetes/kube-state-metrics/) ([source](https://togithub.com/prometheus-community/helm-charts)) | minor | `5.22.0` -> `5.24.0` | --- ### Release Notes <details> <summary>prometheus-community/helm-charts (kube-state-metrics)</summary> ### [`v5.24.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-state-metrics-5.24.0) [Compare Source](https://togithub.com/prometheus-community/helm-charts/compare/kube-state-metrics-5.23.0...kube-state-metrics-5.24.0) Install kube-state-metrics to generate and expose cluster-level metrics #### What's Changed - \[kube-state-metrics] Align probing endpoints with recommendations by [@​SimonKienzler](https://togithub.com/SimonKienzler) in [https://github.com/prometheus-community/helm-charts/pull/4743](https://togithub.com/prometheus-community/helm-charts/pull/4743) **Full Changelog**: prometheus-community/helm-charts@kube-state-metrics-5.23.0...kube-state-metrics-5.24.0 ### [`v5.23.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-state-metrics-5.23.0) [Compare Source](https://togithub.com/prometheus-community/helm-charts/compare/kube-state-metrics-5.22.1...kube-state-metrics-5.23.0) Install kube-state-metrics to generate and expose cluster-level metrics #### What's Changed - \[kube-state-metrics] Allow configuration of startupProbe by [@​SimonKienzler](https://togithub.com/SimonKienzler) in [https://github.com/prometheus-community/helm-charts/pull/4740](https://togithub.com/prometheus-community/helm-charts/pull/4740) #### New Contributors - [@​SimonKienzler](https://togithub.com/SimonKienzler) made their first contribution in [https://github.com/prometheus-community/helm-charts/pull/4740](https://togithub.com/prometheus-community/helm-charts/pull/4740) **Full Changelog**: prometheus-community/helm-charts@kube-state-metrics-5.22.1...kube-state-metrics-5.23.0 ### [`v5.22.1`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-state-metrics-5.22.1) [Compare Source](https://togithub.com/prometheus-community/helm-charts/compare/kube-state-metrics-5.22.0...kube-state-metrics-5.22.1) Install kube-state-metrics to generate and expose cluster-level metrics #### What's Changed - \[kube-state-metrics] - Improve customLabels template flexibility by [@​sarnowski-defense-unicorns](https://togithub.com/sarnowski-defense-unicorns) in [https://github.com/prometheus-community/helm-charts/pull/4738](https://togithub.com/prometheus-community/helm-charts/pull/4738) #### New Contributors - [@​sarnowski-defense-unicorns](https://togithub.com/sarnowski-defense-unicorns) made their first contribution in [https://github.com/prometheus-community/helm-charts/pull/4738](https://togithub.com/prometheus-community/helm-charts/pull/4738) **Full Changelog**: prometheus-community/helm-charts@prometheus-mysql-exporter-2.6.1...kube-state-metrics-5.22.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41LjAiLCJ1cGRhdGVkSW5WZXIiOiIzOC43LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInJlbm92YXRlL2hlbG0iLCJ0eXBlL21pbm9yIl19--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
As in previous PRs, e.g. #3811 or #4696, I would like to enable users of the
kube-state-metricschart to optionally configure astartupProbein theDeployment, if external circumstances require it.Special notes for your reviewer
As requested in the PR template, CC'ing @tariq1890 @mrueg @dotdc
The PRs I looked at as inspiration for this change had different approaches for making the
startupProbeconfigurable, e.g. just passing on the entire value block, or configuring defaults for most fields vs a simplestartupProbe: {}. I opted to keep it similar to thereadinessProbeandlivenessProbealready available in this chart, for consistency.First PR here, happy about any feedback regarding the change itself or the PR process in general.
Checklist
[prometheus-couchdb-exporter])