[prometheus-pushgateway] allow overriding service port name #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickaein
changed the title
Signed-off-by: Isaac Nickaein <[email protected]>
nickaein
force-pushed
the
override-service-portname
branch
from
388dcce to
70c0e16
Compare
Co-authored-by: zeritti <[email protected]> Signed-off-by: Isaac Nickaein <[email protected]>
|
Thanks @zeritti. I wasn't sure whether I should bump the minor version. Counting it as a feature seems reasonable. |
zeritti
approved these changes
Jun 4, 2024
Signed-off-by: zeritti <[email protected]>
Maven35
pushed a commit
to Maven35/helm-charts
that referenced
this pull request
Jun 6, 2024
…us-community#4583) * allow overriding service port name Signed-off-by: Isaac Nickaein <[email protected]> * Update charts/prometheus-pushgateway/Chart.yaml Co-authored-by: zeritti <[email protected]> Signed-off-by: Isaac Nickaein <[email protected]> * Empty commit to invoke DCO check Signed-off-by: zeritti <[email protected]> --------- Signed-off-by: Isaac Nickaein <[email protected]> Signed-off-by: zeritti <[email protected]> Co-authored-by: zeritti <[email protected]>
Maven35
pushed a commit
to Maven35/helm-charts
that referenced
this pull request
Jun 6, 2024
…us-community#4583) * allow overriding service port name Signed-off-by: Isaac Nickaein <[email protected]> * Update charts/prometheus-pushgateway/Chart.yaml Co-authored-by: zeritti <[email protected]> Signed-off-by: Isaac Nickaein <[email protected]> * Empty commit to invoke DCO check Signed-off-by: zeritti <[email protected]> --------- Signed-off-by: Isaac Nickaein <[email protected]> Signed-off-by: zeritti <[email protected]> Co-authored-by: zeritti <[email protected]> Signed-off-by: Maven35 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR introduces the ability to customize the hard-coded port name
httpfor the pushgateway service. This enhancement is necessary for environments where a Prometheus ServiceMonitor already exists on Kubernetes to scrape metrics from the services, using port name different thanhttp(e.g.metrics).Which issue this PR fixes
None
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])