-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus-smartctl-exporter] add rule for device temperature #4572
Merged
zeritti
merged 1 commit into
prometheus-community:main
from
uhthomas:smartctl-exporter-device-temperature
May 29, 2024
Merged
[prometheus-smartctl-exporter] add rule for device temperature #4572
zeritti
merged 1 commit into
prometheus-community:main
from
uhthomas:smartctl-exporter-device-temperature
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeritti
requested changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @uhthomas, for your PR. Please, see my comments below.
…rature Signed-off-by: Thomas Way <[email protected]>
uhthomas
force-pushed
the
smartctl-exporter-device-temperature
branch
from
May 29, 2024 15:23
4dac7ae
to
0c1dc95
Compare
zeritti
approved these changes
May 29, 2024
kireque
referenced
this pull request
in kireque/home-ops
May 29, 2024
… ) (#605) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [prometheus-smartctl-exporter](https://togithub.com/prometheus-community/smartctl_exporter) ([source](https://togithub.com/prometheus-community/helm-charts)) | minor | `0.8.0` -> `0.9.0` | --- ### Release Notes <details> <summary>prometheus-community/helm-charts (prometheus-smartctl-exporter)</summary> ### [`v0.9.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/prometheus-smartctl-exporter-0.9.0) [Compare Source](https://togithub.com/prometheus-community/helm-charts/compare/prometheus-smartctl-exporter-0.8.0...prometheus-smartctl-exporter-0.9.0) A Helm chart for Kubernetes #### What's Changed - \[prometheus-smartctl-exporter] add rule for device temperature by [@​uhthomas](https://togithub.com/uhthomas) in [https://github.com/prometheus-community/helm-charts/pull/4572](https://togithub.com/prometheus-community/helm-charts/pull/4572) #### New Contributors - [@​uhthomas](https://togithub.com/uhthomas) made their first contribution in [https://github.com/prometheus-community/helm-charts/pull/4572](https://togithub.com/prometheus-community/helm-charts/pull/4572) **Full Changelog**: prometheus-community/helm-charts@prometheus-operator-crds-12.0.0...prometheus-smartctl-exporter-0.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODEuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM4MS44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
lukas-unity
pushed a commit
to lukas-unity/helm-charts-1
that referenced
this pull request
Jun 6, 2024
…theus-community#4572) Signed-off-by: Thomas Way <[email protected]> Signed-off-by: Lukas Monkevicius <[email protected]>
Maven35
pushed a commit
to Maven35/helm-charts
that referenced
this pull request
Jun 6, 2024
…theus-community#4572) Signed-off-by: Thomas Way <[email protected]> Signed-off-by: Maven35 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds a rule for device temperature, which can prevent physical damage to devices. I was only alerted about the temperature of my disks as they failed SMART entirely at their 80c threshold.
Which issue this PR fixes
N/A
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter]
)