Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-smartctl-exporter] add rule for device temperature #4572

Conversation

uhthomas
Copy link
Contributor

@uhthomas uhthomas commented May 28, 2024

What this PR does / why we need it

This PR adds a rule for device temperature, which can prevent physical damage to devices. I was only alerted about the temperature of my disks as they failed SMART entirely at their 80c threshold.

image

Which issue this PR fixes

N/A

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@uhthomas uhthomas requested a review from zeritti as a code owner May 28, 2024 22:22
Copy link
Member

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @uhthomas, for your PR. Please, see my comments below.

charts/prometheus-smartctl-exporter/Chart.yaml Outdated Show resolved Hide resolved
@uhthomas uhthomas force-pushed the smartctl-exporter-device-temperature branch from 4dac7ae to 0c1dc95 Compare May 29, 2024 15:23
@zeritti zeritti merged commit fce686e into prometheus-community:main May 29, 2024
4 checks passed
kireque referenced this pull request in kireque/home-ops May 29, 2024
… ) (#605)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[prometheus-smartctl-exporter](https://togithub.com/prometheus-community/smartctl_exporter)
([source](https://togithub.com/prometheus-community/helm-charts)) |
minor | `0.8.0` -> `0.9.0` |

---

### Release Notes

<details>
<summary>prometheus-community/helm-charts
(prometheus-smartctl-exporter)</summary>

###
[`v0.9.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/prometheus-smartctl-exporter-0.9.0)

[Compare
Source](https://togithub.com/prometheus-community/helm-charts/compare/prometheus-smartctl-exporter-0.8.0...prometheus-smartctl-exporter-0.9.0)

A Helm chart for Kubernetes

#### What's Changed

- \[prometheus-smartctl-exporter] add rule for device temperature by
[@&#8203;uhthomas](https://togithub.com/uhthomas) in
[https://github.com/prometheus-community/helm-charts/pull/4572](https://togithub.com/prometheus-community/helm-charts/pull/4572)

#### New Contributors

- [@&#8203;uhthomas](https://togithub.com/uhthomas) made their first
contribution in
[https://github.com/prometheus-community/helm-charts/pull/4572](https://togithub.com/prometheus-community/helm-charts/pull/4572)

**Full Changelog**:
prometheus-community/helm-charts@prometheus-operator-crds-12.0.0...prometheus-smartctl-exporter-0.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODEuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM4MS44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
lukas-unity pushed a commit to lukas-unity/helm-charts-1 that referenced this pull request Jun 6, 2024
Maven35 pushed a commit to Maven35/helm-charts that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants