[kube-prometheus-stack] Thanos Ruler: Support omit externalPrefix with externalPrefixNilUsesHelmValues=true, if ingress is enabled #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
jkroepke
force-pushed
the
ruler/external-prefix
branch
from
247804d to
95f714a
Compare
…h externalPrefixNilUsesHelmValues=true, if ingress is enabled Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
force-pushed
the
ruler/external-prefix
branch
from
95f714a to
420df22
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
|
@QuentinBisson @GMartinez-Sisti If you could take an eye here, I would appreciate it. |
QuentinBisson
previously approved these changes
Jun 3, 2024
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Sure, I have to. |
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
| @@ -31,10 +31,12 @@ spec: | |||
| listenLocal: {{ .Values.thanosRuler.thanosRulerSpec.listenLocal }} | |||
| serviceAccountName: {{ template "kube-prometheus-stack.thanosRuler.serviceAccountName" . }} | |||
| {{- if .Values.thanosRuler.thanosRulerSpec.externalPrefix }} | |||
| externalPrefix: "{{ tpl .Values.thanosRuler.thanosRulerSpec.externalPrefix . }}" | |||
| externalPrefix: {{ tpl .Values.thanosRuler.thanosRulerSpec.externalPrefix . | quote }} | |||
There was a problem hiding this comment.
@jkroepke coming back to reviewing those, is that still needed with the PR to clean up the UsesHelmValues ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
I would like to use
web.prefix-headerinstead an static prefix fromexternalPrefix. Thats works only, if externalPrefix is fully omit.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])