[prometheus-mysql-exporter] enable monitoring not only in release namespace #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mespace Signed-off-by: Kawon1 <[email protected]>
Signed-off-by: Kawon1 <[email protected]>
monotek
previously approved these changes
Dec 7, 2023
Signed-off-by: André Bauer <[email protected]>
Signed-off-by: André Bauer <[email protected]>
monotek
approved these changes
Jan 8, 2024
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…espace (prometheus-community#3905) * [prometheus-mysql-exporter] enable monitoring not only in .Release.Namespace Signed-off-by: Kawon1 <[email protected]> * [prometheus-mysql-exporter] bump chart Signed-off-by: Kawon1 <[email protected]> * update version Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Kawon1 <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mespace
What this PR does / why we need it
This PR enables to monitor namespace or list of namespaces which are not necessary included in
.Release.Namespace. For instance, we would like to deploy serviceMonitor to namespace namedmonitoringbut the desired objects to monitor are deployed withinpostgresnamespace. Before this PR such configuration is not possible. These changes are inspired by kube-state-metrics chart.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])