Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-operator-crds] bump crds to 0.68.0 #3771

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

DrFaust92
Copy link
Contributor

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@DrFaust92 DrFaust92 force-pushed the operator-chart-0.68 branch 2 times, most recently from 33994d2 to 73d1f80 Compare September 10, 2023 13:58
@jkroepke
Copy link
Member

Error: INSTALLATION FAILED: create: failed to create: Secret "sh.helm.release.v1.prometheus-operator-crds-iyt4ktb8mp.v1" is invalid: data: Too long: must have at most 1048576 bytes

@DrFaust92 are you able to create a sub-chart and move all template files into it? Thats what we do at kube-prometheus-stack

https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack/charts/crds

@DrFaust92
Copy link
Contributor Author

jkroepke testing

@jkroepke
Copy link
Member

Please keep them in template dir instead crds dir

@DrFaust92
Copy link
Contributor Author

DrFaust92 commented Sep 10, 2023

if this works ill rebase one more time to clean the PR

@DrFaust92
Copy link
Contributor Author

jkroepke I think this should do it, it was able to template it locally

@DrFaust92
Copy link
Contributor Author

might fix #3654

@jkroepke
Copy link
Member

Look good, thanks for the changes.

From my point of view. Upgrade Guide in form like https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-state-metrics#upgrading-to-v300 would be useful.

The valus annotations is now crds.annotations which should be mention somewhere.

@DrFaust92
Copy link
Contributor Author

jkroepke added, lmk if it looks ok to you

Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jkroepke jkroepke merged commit 33bf16a into prometheus-community:main Sep 11, 2023
Matiasmct pushed a commit to giffgaff/prometheus-charts-backup that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants