-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus-operator-crds] bump crds to 0.68.0 #3771
[prometheus-operator-crds] bump crds to 0.68.0 #3771
Conversation
33994d2
to
73d1f80
Compare
@DrFaust92 are you able to create a sub-chart and move all template files into it? Thats what we do at kube-prometheus-stack |
jkroepke testing |
Please keep them in template dir instead crds dir |
if this works ill rebase one more time to clean the PR |
c8958d6
to
f62dcc0
Compare
jkroepke I think this should do it, it was able to template it locally |
might fix #3654 |
Look good, thanks for the changes. From my point of view. Upgrade Guide in form like https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-state-metrics#upgrading-to-v300 would be useful. The valus |
jkroepke added, lmk if it looks ok to you |
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
9d4c306
to
3d3632d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter]
)