[kube-prometheus-stack] Do not set Default Resource Requests and Limits for Prometheus Config Reloader

[mmianl]

Is your feature request related to a problem ?

At the moment, it's not possible to unset resource requests and/or limits because the default values file specifies these values:

prometheusConfigReloader:
  resources:
      requests:
        cpu: 200m
        memory: 50Mi
      limits:
        cpu: 200m
        memory: 50Mi

The other components in the chart do not specify any default resources which makes sense because it leaves the user with the option to not set cpu and memory requests and limits which is preferred by some users (especially regarding cpu limits).

Describe the solution you'd like.

Remove the default Prometheus Config Reloader resources.

Describe alternatives you've considered.

NONE

Additional context.

No response

[GMartinez-Sisti]

@mmianl you can override by setting it to null:

prometheusConfigReloader:
  resources: null

[mmianl]

@mmianl you can override by setting it to null:

prometheusConfigReloader:
  resources: null

@GMartinez-Sisti I just tried that and it causes a nil pointer error. Also, I think that approach wouldn't allow to specify only cpu requests, but no cpu limit.

[GMartinez-Sisti]

@mmianl you can override by setting it to null:

prometheusConfigReloader:
  resources: null

@GMartinez-Sisti I just tried that and it causes a nil pointer error. Also, I think that approach wouldn't allow to specify only cpu requests, but no cpu limit.

You're right. I forgot this is different and used in a different way. Not the usual resources map for a container.

[mmianl]

@mmianl you can override by setting it to null:

prometheusConfigReloader:
  resources: null

@GMartinez-Sisti I just tried that and it causes a nil pointer error. Also, I think that approach wouldn't allow to specify only cpu requests, but no cpu limit.

You're right. I forgot this is different and used in a different way. Not the usual resources map for a container.

@GMartinez-Sisti I came up with this (#3813) solution, what do you think of it?