Skip to content

Commit

Permalink
[kube-prometheus-stack] remove default cpu and memory requests and li… (
Browse files Browse the repository at this point in the history
#3813)

* [kube-prometheus-stack] remove default cpu and memory requests and limits from prometheus config reloader (#3812)

Signed-off-by: Markus Müllner <[email protected]>

* [kube-prometheus-stack] update prometheus operator deployment template (#3812)

Signed-off-by: Markus Müllner <[email protected]>

* [kube-prometheus-stack] fix prometheus operator deployment template by wrapping nullable values (#3812)

Signed-off-by: Markus Müllner <[email protected]>

* [kube-prometheus-stack] use default value instead of if in prometheus operator deployment template (#3812)

Signed-off-by: Markus Müllner <[email protected]>

---------

Signed-off-by: Markus Müllner <[email protected]>
  • Loading branch information
mmianl authored Sep 21, 2023
1 parent b8b561e commit fe84f27
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion charts/kube-prometheus-stack/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ name: kube-prometheus-stack
sources:
- https://github.com/prometheus-community/helm-charts
- https://github.com/prometheus-operator/kube-prometheus
version: 51.0.3
version: 51.1.0
appVersion: v0.68.0
kubeVersion: ">=1.19.0-0"
home: https://github.com/prometheus-operator/kube-prometheus
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ spec:
{{- else }}
- --prometheus-config-reloader={{ $configReloaderRegistry }}/{{ .Values.prometheusOperator.prometheusConfigReloader.image.repository }}:{{ .Values.prometheusOperator.prometheusConfigReloader.image.tag | default .Chart.AppVersion }}
{{- end }}
- --config-reloader-cpu-request={{ .Values.prometheusOperator.prometheusConfigReloader.resources.requests.cpu }}
- --config-reloader-cpu-limit={{ .Values.prometheusOperator.prometheusConfigReloader.resources.limits.cpu }}
- --config-reloader-memory-request={{ .Values.prometheusOperator.prometheusConfigReloader.resources.requests.memory }}
- --config-reloader-memory-limit={{ .Values.prometheusOperator.prometheusConfigReloader.resources.limits.memory }}
- --config-reloader-cpu-request={{ (((.Values.prometheusOperator.prometheusConfigReloader.resources).requests).cpu) | default 0 }}
- --config-reloader-cpu-limit={{ (((.Values.prometheusOperator.prometheusConfigReloader.resources).limits).cpu) | default 0 }}
- --config-reloader-memory-request={{ (((.Values.prometheusOperator.prometheusConfigReloader.resources).requests).memory) | default 0 }}
- --config-reloader-memory-limit={{ (((.Values.prometheusOperator.prometheusConfigReloader.resources).limits).memory) | default 0 }}
{{- if .Values.prometheusOperator.prometheusConfigReloader.enableProbe }}
- --enable-config-reloader-probes=true
{{- end }}
Expand Down
14 changes: 7 additions & 7 deletions charts/kube-prometheus-stack/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2377,13 +2377,13 @@ prometheusOperator:
enableProbe: false

# resource config for prometheusConfigReloader
resources:
requests:
cpu: 200m
memory: 50Mi
limits:
cpu: 200m
memory: 50Mi
resources: {}
# requests:
# cpu: 200m
# memory: 50Mi
# limits:
# cpu: 200m
# memory: 50Mi

## Thanos side-car image when configured
##
Expand Down

0 comments on commit fe84f27

Please sign in to comment.