Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : AlertManager Role, allow using web config file #267

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

modship
Copy link

@modship modship commented Dec 19, 2023

This PR allow using web config file, in my case i need to use basic auth

Exemple :

alertmanager_web_config:
  basic_auth_users:
    John: $2a$12$9kqglntQUzvOFu2cvEYZ0.H6sXuho5Xdc.ID.C2hNtlCYF6q/RXWG
    Doe: $2a$12$sIB6/w8/4Fn5EWaAdrpSGuRqIhkrXzSnQSxOqbiSPhTbdHWkC.oKG

@modship modship changed the title Allow using web config file feat : Allow using web config file Dec 19, 2023
@modship modship changed the title feat : Allow using web config file feat : AlertManager Role, allow using web config file Dec 19, 2023
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not follow the implementation pattern of the other roles.

This needs a DCO sign-off. You can use git commit -s --amend to add it.

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to use ansible.builtin.template like the other roles do.

@gardar
Copy link
Member

gardar commented Oct 18, 2024

@modship can you please rebase so that we can get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roles/alertmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants