Add more test, refactor batcher internals #320
clippy
6 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 6 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.74.0 (79e9716c9 2023-11-13)
- cargo 1.74.0 (ecb9851af 2023-10-18)
- clippy 0.1.74 (79e9716 2023-11-13)
Annotations
Check failure on line 10 in plugin/examples/polysynth/src/poly_oscillator.rs
github-actions / clippy
fields `voice_buffer` and `active_voice_count` are never read
error: fields `voice_buffer` and `active_voice_count` are never read
--> plugin/examples/polysynth/src/poly_oscillator.rs:10:5
|
9 | pub struct PolyOscillator {
| -------------- fields in this struct
10 | voice_buffer: Box<[Voice]>,
| ^^^^^^^^^^^^
11 | active_voice_count: usize,
| ^^^^^^^^^^^^^^^^^^
Check failure on line 6 in plugin/examples/polysynth/src/poly_oscillator.rs
github-actions / clippy
field `oscillator` is never read
error: field `oscillator` is never read
--> plugin/examples/polysynth/src/poly_oscillator.rs:6:5
|
5 | struct Voice {
| ----- field in this struct
6 | oscillator: SquareOscillator,
| ^^^^^^^^^^
|
= note: `Voice` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
Check failure on line 17 in plugin/examples/polysynth/src/oscillator.rs
github-actions / clippy
methods `reset`, `set_frequency`, and `next_sample` are never used
error: methods `reset`, `set_frequency`, and `next_sample` are never used
--> plugin/examples/polysynth/src/oscillator.rs:17:12
|
8 | impl SquareOscillator {
| --------------------- methods in this implementation
...
17 | pub fn reset(&mut self) {
| ^^^^^
...
22 | pub fn set_frequency(&mut self, _new_frequency: f32) {
| ^^^^^^^^^^^^^
...
27 | pub fn next_sample(&mut self) -> f32 {
| ^^^^^^^^^^^
Check failure on line 5 in plugin/examples/polysynth/src/oscillator.rs
github-actions / clippy
field `frequency_to_phase_increment_ratio` is never read
error: field `frequency_to_phase_increment_ratio` is never read
--> plugin/examples/polysynth/src/oscillator.rs:5:5
|
4 | pub struct SquareOscillator {
| ---------------- field in this struct
5 | frequency_to_phase_increment_ratio: f32,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `SquareOscillator` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
Check failure on line 32 in plugin/examples/polysynth/src/poly_oscillator.rs
github-actions / clippy
unused variable: `output_buffer`
error: unused variable: `output_buffer`
--> plugin/examples/polysynth/src/poly_oscillator.rs:32:45
|
32 | pub fn generate_next_samples(&mut self, output_buffer: &mut [f32]) {
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_buffer`
Check failure on line 28 in plugin/examples/polysynth/src/poly_oscillator.rs
github-actions / clippy
unused variable: `event`
error: unused variable: `event`
--> plugin/examples/polysynth/src/poly_oscillator.rs:28:37
|
28 | pub fn process_event(&mut self, event: &UnknownEvent) {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_event`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`