refactor(Color): improve Color lib (types, etc.)
#352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmillr
force-pushed
the
refactor-colorlib
branch
2 times, most recently
from
f414fb5 to
ecb2c9b
Compare
- Fixup types and doc-comment descriptions. The `Color` module and `Color` instances are now well-typed providing LSP completion and type-hinting. The `Color` type has been renamed and namspaced under `GhTheme.*`. Types provided by the `Color` module are namespaced under `GhTheme.Color.*`. The reason for the namespacing is because the Lua LSP considers all defined types to be global. - Remove duplicated code in `__call` and `new()`. - Throw an error if the argument given to the `Color` constructor is of invalid type. Previously there was no error and it just returned `nil`.
tmillr
force-pushed
the
refactor-colorlib
branch
from
ecb2c9b to
5b607d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup types and doc-comment descriptions. The
Colormodule andColorinstances are now well-typed providing LSP completion and type-hinting. TheColortype has been renamed and namspaced underGhTheme.*. Types provided by theColormodule are namespaced underGhTheme.Color.*. The reason for the namespacing is because the Lua LSP considers all defined types to be global.Remove duplicated code in
__callandnew().Throw an error if the argument given to the
Colorconstructor is of invalid type. Previously there was no error and it just returnednil.