Lint code using oxlint (#365)

projectwallace · Dec 26, 2023 · 41ad5dc · 41ad5dc
1 parent d937b4b
commit 41ad5dc
Show file tree

Hide file tree

Showing 6 changed files with 170 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -10,6 +10,15 @@ on:
     branches: [master]
 
 jobs:
+  lint:
+    name: Lint JS
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+      - name: Lint JS
+        run: npx --yes oxlint@latest
+
   test:
     name: Unit tests
     runs-on: ubuntu-latest

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -27,6 +27,7 @@
   },
   "scripts": {
     "test": "uvu",
+    "lint": "oxlint",
     "build": "microbundle"
   },
   "keywords": [
@@ -52,6 +53,7 @@
   },
   "devDependencies": {
     "microbundle": "^0.15.1",
+    "oxlint": "^0.0.22",
     "uvu": "^0.5.6"
   },
   "mangle": {

diff --git a/src/index.test.js b/src/index.test.js
@@ -214,7 +214,6 @@ Api('handles empty input gracefully', () => {
         "total": 0,
         "totalUnique": 0,
         "unique": {},
-        "total": 0,
         "uniquenessRatio": 0,
         "items": []
       },

diff --git a/src/rules/rules.test.js b/src/rules/rules.test.js
@@ -59,7 +59,6 @@ Rules('should handle CSS without rules', () => {
       range: 0,
       sum: 0,
       items: [],
-      items: [],
       unique: {},
       total: 0,
       totalUnique: 0,

diff --git a/src/selectors/utils.js b/src/selectors/utils.js
@@ -101,7 +101,7 @@ export function getComplexity(selector) {
     }
 
     if (node.type === AttributeSelector) {
-      if (Boolean(node.value)) {
+      if (node.value) {
         complexity++
       }
       if (hasVendorPrefix(node.name.name)) {