Remove Kapitan patch #114
Draft
Remove Kapitan patch #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
docs/remove-kapitan-patch
branch
2 times, most recently
from
455a8fb to
d905e09
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
docs/remove-kapitan-patch
branch
from
d905e09 to
17fb402
Compare
|
Wait with merging until we are sure that Commodore is updated to >= 1.24.0 for all our tooling which may apply the patch. |
Benchmark for 756a001Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With kapicorp/kapitan#1059 we won't need the Kapitan patch anymore. This PR removes the patch and updates the README to match the new way to use reclass-rs in Kapitan.
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog