Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to perform a restore from k8up backup #90

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

HappyTetrahedron
Copy link
Contributor

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@HappyTetrahedron HappyTetrahedron added the documentation Improvements or additions to documentation label Aug 19, 2024
@HappyTetrahedron HappyTetrahedron requested a review from a team August 19, 2024 09:28
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall 😊🚀

docs/modules/ROOT/partials/vault-warning.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/restore-from-backup.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/restore-from-backup.adoc Outdated Show resolved Hide resolved
+
[source,shell]
----
kubectl edit secret -n ${VAULT_INSTANCE_NAME} ${VAULT_INSTANCE_NAME}-seal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be nice to have a copy paste-able command here since updating secrets is a PITA. Especally if you encode a newline into the base64 by accident.

docs/modules/ROOT/pages/how-tos/restore-from-backup.adoc Outdated Show resolved Hide resolved
@HappyTetrahedron HappyTetrahedron merged commit 7d92ed0 into master Aug 26, 2024
7 checks passed
@HappyTetrahedron HappyTetrahedron deleted the docs/restore-procedure branch August 26, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants