Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up entry points provided by the Python package #1040

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

simu
Copy link
Member

@simu simu commented Oct 28, 2024

We remove the legacy development commands local_reveal and compile. These commands have never worked correctly when the package is installed from PyPI since the package never bundled the tools/tools.py file.

Instead, we add a command kapitan which exposes the Kapitan CLI as an entrypoint for the syn-commodore package. This command will enable users who install Commodore with uv tool install to use the bundled Kapitan as if it was an installed tool.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog

@simu simu added the enhancement New feature or request label Oct 28, 2024
@simu simu requested a review from a team October 28, 2024 14:58
We remove the legacy development commands `local_reveal` and `compile`.
These commands have never worked correctly when the package is installed
from PyPI since the package never bundled the `tools/tools.py` file.

Instead, we add a command `kapitan` which exposes the Kapitan CLI as an
entrypoint for the syn-commodore package. This command will enable users
who install Commodore with `uv tool install` to use the bundled Kapitan
as if it was an installed tool.
@simu simu force-pushed the cleanup-package-commands branch from 6912547 to a36b1f1 Compare October 28, 2024 15:41
@simu simu marked this pull request as ready for review October 28, 2024 15:45
@simu simu requested a review from a team as a code owner October 28, 2024 15:45
@simu simu merged commit 35457bd into master Oct 28, 2024
20 checks passed
@simu simu deleted the cleanup-package-commands branch October 28, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants