Stomp-Client: add authentication to connection process #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
|
||
| @Override | ||
| public String getPassword() { | ||
| return client.getAuthentiactionPassword(); |
There was a problem hiding this comment.
There's a typo, should be client.getAuthenticationPassword().
|
An Idea I had to get around the colon-separation issue is to require username and password to be url-encoded and throw an error if there's more than one colon in the getUserInfo() string. What do you think? |
This should now be more compliant to RFC3986. RFC3986 (3.2.1) states that the username ends at the first colon, and everything after that is to be considered parameters for the authorization scheme. (Here, it will be the password only.)
|
I had a good re-read of RFC3986 (URI syntax) and rewrote the Authorization extraction to reflect that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #15
Known issues: you can't have passwords or usernames with colons in them. (Anyone know of suitable framework code to parse a URI.getUserInfo() in a standards-compliant way?)