-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand ax.scatter kwargs that can be used #2445
Conversation
Performance benchmarks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s so incredibly nice to see examples updated together with code. And thanks for the screenshot, always appreciated!
Looks clean, let’s give others also a bit of time to review.
At some point we should add a note or section about handeling axes and their arguments (including things like colormapping) to the tutorial. Can be a follow up.
If linewith and edgecolor are handled analogously to color and size, basically everything in ax.scatter is controllable and we can also close #2341. I might just do that in a seperate PR to keep this one clear and focussed. |
I would say go ahead and merge tomorrow morning, our US-timezone friends can check tonight and otherwise it's good to go. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
#2430 added the possibility to pass keyword arguments on to the various draw functions. This builds on that by passing any keyword arguments not used explicitly in any of the draw functions on to
ax.scatter
. This can, for example, be used to set a custom colormap, control vmin, vmax etc., as shown in the updated Boltzmann wealth example (see below for a screenshot)Closes #1183.