Updates to Epstein example #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* shift to von neuman grid * update of perceived risk with round operator * introduction of enum for state * cleanup of statistics gathering to use enum * update of visualization code to be consistent with what is currently supported when drawing new_style discrete grids
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Performance benchmarks:
|
EwoutH
reviewed
Oct 27, 2024
EwoutH
reviewed
Oct 27, 2024
Comment on lines
75
to
+78
| for cell in self.grid.all_cells: | ||
| if self.random.random() < self.cop_density: | ||
| cop = Cop(self, vision=self.cop_vision) | ||
| cop.move_to(cell) | ||
| klass = self.random.choices( | ||
| [Citizen, Cop, None], | ||
| cum_weights=[citizen_density, citizen_density + cop_density, 1], |
There was a problem hiding this comment.
Seems a bit complicated. Can't we just generate cop_density * cells cops and citizen_density * cells citizens, and place them randomly?
Or aren't they allowed to start at the same cell?
There was a problem hiding this comment.
There can be at most one agent per cell.
EwoutH
approved these changes
Oct 27, 2024
I haven't done any testing, this was really focussed on getting the proper behavior back. |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the Epstein model to address #2423. Next to shifting to a von Neumann grid, there are several other changes.
round. This is based on an extensive literature that shows that without it, the original Epstein results cannot be reproduced.The net result is shown below.