Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #36 - Allows a user to select an existing resource group. I... #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehamai
Copy link
Contributor

@ehamai ehamai commented Apr 21, 2015

Fixes issue #36 - Allows a user to select an existing resource group. If it's a new RG, then it will attmept to use the site or sql location. If it cannot resolve either, it will default to East US

… If it's a new RG, then it will attmept to use the site or sql location. If it cannot resolve either, it will default to East US
if (!$scope.formData.tenant
|| !$scope.formData.subscription
|| !$scope.formData.params
|| (creatingNewRg() && !$scope.formData.existingResourceGroup.name)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newRG

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this check isn't necessary because it gets taken care of by regex below so I removed it.

@tomkerkhove
Copy link

Sounds like a feasible feature to have, what's the status here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants