Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update latest API for guest configuration #324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mgreenegit
Copy link

It appears that the "definitions" file is no longer needed? Confirm?

@balag0
Copy link
Contributor

balag0 commented Sep 7, 2021

If there is a json file that references an item from the definitions file, then the definitions file will be needed.
Does having the definitions file cause any issues or you are just doing some cleanup?

@mgreenegit
Copy link
Author

just cleanup. what is the best way to tell if it is needed?

@balag0
Copy link
Contributor

balag0 commented Sep 8, 2021

Easiest way is to run a local copy of this app. On launching the app, all the swaggers will be parsed and there will be a filenotfoundexception or definitionnotfound exception for any missing but referenced files.

Instructions might be a little outdated but you should be able to get the general idea.
https://github.com/projectkudu/AzureResourceExplorer#instructions

Other option is to walk through different files and see if they have references to other files.

@mgreenegit
Copy link
Author

confirmed it is needed. restored the file.

"$ref": "./examples/getGuestConfigurationAssignment.json"
}
{
"$ref": "../../common/v1/definitions.json#/parameters/SubscriptionIdParameter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common types are available at a different relative path (you can see where the old file was referencing parameters/SubscriptionIdParameter from as an example)

"$ref": "./examples/deleteGuestConfigurationAssignment.json"
}
{
"$ref": "../../common/v1/definitions.json#/parameters/VmNameParameter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this type is not available in the common-types file, then we would need a local copy of this file in this folder and update the path to reference from that newly added file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants