Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding activities in retrospect is very hard #630

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Commits on Aug 14, 2020

  1. Update edit_activity.py to every component in form be aware of select…

    …ed date
    
    For activity in cmdline: `some activity` (without date and time)
    - checked incrementing and decrementing day
    - checked date picker
    - checked date picker set to one date and cmdline on another date (cmdline has higher priority)
    
    This fixes projecthamster#627 Adding activities in retrospect is very hard.
    gsobczyk committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    f48d1ae View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Configuration menu
    Copy the full SHA
    137075f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2bb90fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b120a88 View commit details
    Browse the repository at this point in the history
  4. CmdLineEntry: Remove original_fact

    This was unused.
    matthijskooijman committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    295ed12 View commit details
    Browse the repository at this point in the history
  5. CmdLineEntry: Prevent duplicate fact parsing

    The `extract_search` helper function was passed the text and parsed a
    Fact from that. However, all places calling this function already parsed
    that same text, so easier to just pass the parsed Fact rather than the
    text.
    matthijskooijman committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    46f8cc7 View commit details
    Browse the repository at this point in the history
  6. CmdLineEntry: Use self.default_day when parsing

    Inside CmdLineEntry, the text was previously parsed without specifying a
    default_day, causing the (start) date of that parsed fact to be the
    current date.
    
    This was mostly harmless, since these parsed facts are
    only used to generate completions (the actual fact to be saved is
    parsed by CustomFactController, which does apply the right date).
    
    However, in some cases, this caused suggestions to look slightly weird
    (such as when editing a fact with a start time before today and without
    end time, the "stop now" entry would show an explicit date, because the
    serialization *did* use default_day). By using the default_day also for
    parsing, the CmdLineEntry always has the right idea about the fact that
    it is creating, which removes these small weirdnesses.
    matthijskooijman committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    53c414b View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. CustomFactController: Update current date on cmdline changes

    This ensures that `self.date` remains correct, which indirectly makes
    sure the "dayline" at the top of the window is updated, and ensures that
    the cmdline also uses the right date for subsequent serialization and
    completions.
    matthijskooijman committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    cf3d13a View commit details
    Browse the repository at this point in the history