-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding activities in retrospect is very hard #630
Open
gsobczyk
wants to merge
8
commits into
projecthamster:master
Choose a base branch
from
gsobczyk:adding-activities-is-hard
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding activities in retrospect is very hard #630
gsobczyk
wants to merge
8
commits into
projecthamster:master
from
gsobczyk:adding-activities-is-hard
Commits on Aug 14, 2020
-
Update edit_activity.py to every component in form be aware of select…
…ed date For activity in cmdline: `some activity` (without date and time) - checked incrementing and decrementing day - checked date picker - checked date picker set to one date and cmdline on another date (cmdline has higher priority) This fixes projecthamster#627 Adding activities in retrospect is very hard.
Configuration menu - View commit details
-
Copy full SHA for f48d1ae - Browse repository at this point
Copy the full SHA f48d1aeView commit details
Commits on Nov 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 137075f - Browse repository at this point
Copy the full SHA 137075fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bb90fc - Browse repository at this point
Copy the full SHA 2bb90fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b120a88 - Browse repository at this point
Copy the full SHA b120a88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 295ed12 - Browse repository at this point
Copy the full SHA 295ed12View commit details -
CmdLineEntry: Prevent duplicate fact parsing
The `extract_search` helper function was passed the text and parsed a Fact from that. However, all places calling this function already parsed that same text, so easier to just pass the parsed Fact rather than the text.
Configuration menu - View commit details
-
Copy full SHA for 46f8cc7 - Browse repository at this point
Copy the full SHA 46f8cc7View commit details -
CmdLineEntry: Use self.default_day when parsing
Inside CmdLineEntry, the text was previously parsed without specifying a default_day, causing the (start) date of that parsed fact to be the current date. This was mostly harmless, since these parsed facts are only used to generate completions (the actual fact to be saved is parsed by CustomFactController, which does apply the right date). However, in some cases, this caused suggestions to look slightly weird (such as when editing a fact with a start time before today and without end time, the "stop now" entry would show an explicit date, because the serialization *did* use default_day). By using the default_day also for parsing, the CmdLineEntry always has the right idea about the fact that it is creating, which removes these small weirdnesses.
Configuration menu - View commit details
-
Copy full SHA for 53c414b - Browse repository at this point
Copy the full SHA 53c414bView commit details
Commits on Nov 21, 2020
-
CustomFactController: Update current date on cmdline changes
This ensures that `self.date` remains correct, which indirectly makes sure the "dayline" at the top of the window is updated, and ensures that the cmdline also uses the right date for subsequent serialization and completions.
Configuration menu - View commit details
-
Copy full SHA for cf3d13a - Browse repository at this point
Copy the full SHA cf3d13aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.