-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #75
base: main
Are you sure you want to change the base?
Update README.md #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments and questions.
@@ -1,7 +1,7 @@ | |||
# ProjectDiscovery Documentation | |||
|
|||
<h4 align="center"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This combination of markdown and HTML is really weird. I suggest just using markdown.
@@ -19,26 +19,24 @@ | |||
|
|||
--- | |||
|
|||
## Development | |||
## Build docs locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should have a separate section or separate topic with guidance for actually working on these docs.
1. Install mintlify with `npm i -g mintlify@latest` | ||
1. Run `mintlify dev` | ||
1. Fork this repository. | ||
1. Install mintlify with `npm i -g mintlify@latest`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm should be listed in a Prerequisites section, along with installing mintlify.
Also, does the user ever need to update Mintlify?
1. Run `mintlify dev` | ||
1. Fork this repository. | ||
1. Install mintlify with `npm i -g mintlify@latest`. | ||
1. Run `mintlify dev`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do they run this? Root level of docs folder, I assume? Also, where will the docs build show up? Does it go to a default port in their default browser? What should they expect?
1. Run `mintlify dev` | ||
1. Fork this repository. | ||
1. Install mintlify with `npm i -g mintlify@latest`. | ||
1. Run `mintlify dev`. | ||
|
||
## Deploying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear what you are deploying. Do you mean "Deploy updated files"? "Deploy new documentation"? And where is it getting deployed?
And when all this is done, how do you get files from your local fork back to the main project? (Assume you are talking to a technical writer who wants to get some practice in open source. This is super common.)
|
||
1. Build the JS Protocol Docs | ||
1. Build the JS Protocol Docs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean JavaScript? If so, spell it out on the first use.
|
||
1. Build the JS Protocol Docs | ||
1. Build the JS Protocol Docs: | ||
|
||
- `npm install -g jsdoc-to-markdown` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, where do you run this? And do they have to be separate commands, or can you run them together? If you can run them together, then why aren't they in a code block?
|
||
- `npm install -g jsdoc-to-markdown` | ||
- `./bin/jsdocs.sh` | ||
|
||
2. Build the PDCP API reference documentation | ||
2. Build the PDCP API reference documentation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember, whoever is running this might be new to the project. Tell them what PDCP API documentation is, preferably in the section about actually working on docs, which does not yet exist.
|
||
- `npm install -g jsdoc-to-markdown` | ||
- `./bin/jsdocs.sh` | ||
|
||
2. Build the PDCP API reference documentation | ||
2. Build the PDCP API reference documentation: | ||
|
||
- Either download the latest `openapi.yaml` manually or run `./bin/download-api.sh` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Download from where? And couldn't this be automated in a makefile or something?
3. Mintlify handles the deployment automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a user, this does not tell me how I know if the deployment is successful, or what to do if I don't see updated files.
Minor edits and a bunch of comments for the README. Documentation fixes are a great way for new contributors to participate and learn about a project, so you want it to be as friendly as possible.
TL;DR - You guys are missing a lot of information. I recommend: